Stream: git-wasmtime

Topic: wasmtime / PR #9976 fix: `no_std` timing module

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 12:46):

JonasKruckenberg edited PR #9976.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 15:06):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 15:06):

bjorn3 created PR review comment:

This should probably return a private type to ensure it can't be downcasted.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 15:07):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 15:07):

bjorn3 created PR review comment:

  1. where is this function used?
  2. It should probably be pub(crate) instead.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 10 2025 at 15:08):

bjorn3 edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 11:31):

JonasKruckenberg updated PR #9976.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 11:32):

JonasKruckenberg submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 11:32):

JonasKruckenberg created PR review comment:

okay maybe this is stupid of me, but why would that be an issue?

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 11:32):

JonasKruckenberg submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 11:32):

JonasKruckenberg created PR review comment:

yup, good catch 👍🏻

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 13:41):

bjorn3 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 13:41):

bjorn3 created PR review comment:

It is not that much of an issue, but if in the future we were to add an actually working profiler (eg by using atomics and aggregating statistics for all threads), it would technically be a breaking change to change the type stored in the Box<dyn Any> as now .downcast::<()>() for consumers would fail. I don't think anyone will write code like that though.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 19:38):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jan 13 2025 at 19:58):

fitzgen merged PR #9976.

Last updated: Jan 24 2025 at 00:11 UTC