Wasmtime GitHub notifications bot (Jan 10 2025 at 01:37): Wasmtime GitHub notifications bot (Jan 10 2025 at 01:37):alexcrichton opened PR #9971 from alexcrichton:edition2024 to bytecodealliance:main:
This is a test to see what breaks in CI when updating to the 2024 edition. The edition won't actually be released until February of this year and we won't be able to use it until two releases after that. This is just a test in the meantime to smooth the future transition.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 10 2025 at 01:39):alexcrichton updated PR #9971.
Wasmtime GitHub notifications bot (Jan 10 2025 at 01:48):alexcrichton updated PR #9971.
Wasmtime GitHub notifications bot (Jan 10 2025 at 16:19):alexcrichton closed without merge PR #9971.
Wasmtime GitHub notifications bot (Jan 10 2025 at 16:19):alexcrichton commented on PR #9971:
Learnings here:
- A few miscellaneous things were split out here and there (e.g. failing doctests)
- Looks like this is going to be a "reformat the world" transition, presumably due to newer defaults in rustfmt
- The windows-specific failures are due to https://github.com/rust-lang/rust/pull/131072, not the edition itself, and that's coming in 1.85. We'll just need to update some tests to expect success instead of expecting failure.
Otherwise I think we're bsaically good to go :+1:
Last updated: Jan 24 2025 at 00:11 UTC