Stream: git-wasmtime

Topic: wasmtime / PR #9967 pulley: Fix a panic in using a return...

Wasmtime GitHub notifications bot (Jan 09 2025 at 20:41):

alexcrichton opened PR #9967 from alexcrichton:pulley-retptr-fix to bytecodealliance:main:

This fixes a panic in the pulley backend introduced in #9874 which comes up when using a return pointer on call instructions. This would shuffle the uses list of registers to not be sorted like the assertion was expecting. The fix in this commit is to just go ahead and sort the list of uses to ensure that registers are peeled off in order.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 09 2025 at 20:41):

alexcrichton requested abrown for a review on PR #9967.

Wasmtime GitHub notifications bot (Jan 09 2025 at 20:41):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9967.

Wasmtime GitHub notifications bot (Jan 09 2025 at 20:41):

alexcrichton requested fitzgen for a review on PR #9967.

Wasmtime GitHub notifications bot (Jan 09 2025 at 20:41):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9967.

Wasmtime GitHub notifications bot (Jan 13 2025 at 17:38):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jan 13 2025 at 18:11):

abrown merged PR #9967.

Last updated: Jan 24 2025 at 00:11 UTC