Wasmtime GitHub notifications bot (Jan 09 2025 at 19:07): Wasmtime GitHub notifications bot (Jan 09 2025 at 19:07):alexcrichton opened PR #9964 from alexcrichton:unsafe-attr-outside-unsafe to bytecodealliance:main:
This commit enables the
unsafe-attr-outside-unsafelint in rustc used in transitioning to the 2024 edition. This requires that the#[no_mangle]attribute is replaced in favor of#[unsafe(no_mangle)]. This mostly affects the C API of wasmtime and most of the changes here are a simple search/replace.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 09 2025 at 19:07):alexcrichton requested pchickey for a review on PR #9964.
Wasmtime GitHub notifications bot (Jan 09 2025 at 19:07):alexcrichton requested wasmtime-default-reviewers for a review on PR #9964.
Wasmtime GitHub notifications bot (Jan 09 2025 at 19:07):alexcrichton requested wasmtime-core-reviewers for a review on PR #9964.
Wasmtime GitHub notifications bot (Jan 09 2025 at 19:12):alexcrichton updated PR #9964.
Wasmtime GitHub notifications bot (Jan 09 2025 at 19:30):alexcrichton updated PR #9964.
Wasmtime GitHub notifications bot (Jan 09 2025 at 21:01):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Jan 09 2025 at 21:30):alexcrichton merged PR #9964.
Last updated: Jan 24 2025 at 00:11 UTC