Stream: git-wasmtime

Topic: wasmtime / PR #9959 Winch: i8x16.shuffle for x64 with AVX

Wasmtime GitHub notifications bot (Jan 13 2025 at 19:36):

jeffcharles edited PR #9959.

Wasmtime GitHub notifications bot (Jan 13 2025 at 19:42):

jeffcharles updated PR #9959.

Wasmtime GitHub notifications bot (Jan 13 2025 at 19:47):

jeffcharles updated PR #9959.

Wasmtime GitHub notifications bot (Jan 13 2025 at 19:51):

jeffcharles edited PR #9959:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Part of #8093. Implements i8x16.shuffle on x64 with AVX extensions.

Wasmtime GitHub notifications bot (Jan 13 2025 at 23:25):

jeffcharles updated PR #9959.

Wasmtime GitHub notifications bot (Jan 14 2025 at 14:40):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jan 14 2025 at 14:40):

saulecabrera created PR review comment:

One small suggestion perhaps to improve readability, given that the then branch is somewhat lengthy, could we invert the check so that we return early in case there's no avx support?

if !self.flags().has_avx() {
  bail!(...);
}

// ....
Ok(())

Wasmtime GitHub notifications bot (Jan 15 2025 at 15:59):

jeffcharles updated PR #9959.

Wasmtime GitHub notifications bot (Jan 15 2025 at 16:14):

jeffcharles updated PR #9959.

Wasmtime GitHub notifications bot (Jan 15 2025 at 16:20):

jeffcharles updated PR #9959.

Wasmtime GitHub notifications bot (Jan 15 2025 at 16:20):

jeffcharles requested saulecabrera for a review on PR #9959.

Wasmtime GitHub notifications bot (Jan 15 2025 at 16:21):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Jan 15 2025 at 18:37):

saulecabrera merged PR #9959.

Last updated: Jan 24 2025 at 00:11 UTC