Stream: git-wasmtime

Topic: wasmtime / PR #9954 winch: implement atomic load operatio...

Wasmtime GitHub notifications bot (Jan 09 2025 at 15:36):

MarinPostma requested cfallin for a review on PR #9954.

Wasmtime GitHub notifications bot (Jan 09 2025 at 15:36):

MarinPostma opened PR #9954 from MarinPostma:main to bytecodealliance:main:

this PR implements atomic loads in wich for x64. This includes:

• i32.atomic.load8_u
• i32.atomic.load16_u
• i32.atomic.load
• i64.atomic.load8_u
• i64.atomic.load16_u
• i64.atomic.load32_u
• i64.atomic.load

https://github.com/bytecodealliance/wasmtime/issues/9734

Wasmtime GitHub notifications bot (Jan 09 2025 at 15:36):

MarinPostma requested wasmtime-core-reviewers for a review on PR #9954.

Wasmtime GitHub notifications bot (Jan 09 2025 at 15:36):

MarinPostma requested alexcrichton for a review on PR #9954.

Wasmtime GitHub notifications bot (Jan 09 2025 at 15:36):

MarinPostma requested wasmtime-compiler-reviewers for a review on PR #9954.

Wasmtime GitHub notifications bot (Jan 09 2025 at 15:37):

MarinPostma edited PR #9954:

this PR enable the thread feature for x64 in Winch, and implements atomic loads. This includes:

• i32.atomic.load8_u
• i32.atomic.load16_u
• i32.atomic.load
• i64.atomic.load8_u
• i64.atomic.load16_u
• i64.atomic.load32_u
• i64.atomic.load

https://github.com/bytecodealliance/wasmtime/issues/9734

Wasmtime GitHub notifications bot (Jan 09 2025 at 15:44):

alexcrichton requested saulecabrera for a review on PR #9954.

Wasmtime GitHub notifications bot (Jan 09 2025 at 15:49):

MarinPostma updated PR #9954.

Wasmtime GitHub notifications bot (Jan 09 2025 at 15:51):

MarinPostma updated PR #9954.

Wasmtime GitHub notifications bot (Jan 09 2025 at 15:52):

MarinPostma updated PR #9954.

Wasmtime GitHub notifications bot (Jan 09 2025 at 18:46):

github-actions[bot] commented on PR #9954:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jan 09 2025 at 19:45):

github-actions[bot] commented on PR #9954:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Jan 09 2025 at 23:10):

MarinPostma closed without merge PR #9954.

Wasmtime GitHub notifications bot (Jan 09 2025 at 23:10):

MarinPostma updated PR #9954.

Last updated: Jan 24 2025 at 00:11 UTC