Stream: git-wasmtime

Topic: wasmtime / PR #9944 pulley: Implement the wide-arithmetic...

Wasmtime GitHub notifications bot (Jan 07 2025 at 21:36):

alexcrichton opened PR #9944 from alexcrichton:pulley-wide-arithmetic to bytecodealliance:main:

Add a few minor instructions/lowerings for the new operations added as part of the wide-arithmetic proposal. These are all part of the "extended" opcode set since they shouldn't be common and if they're performance critical you probably want a native backend instead.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jan 07 2025 at 21:36):

alexcrichton requested cfallin for a review on PR #9944.

Wasmtime GitHub notifications bot (Jan 07 2025 at 21:36):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9944.

Wasmtime GitHub notifications bot (Jan 07 2025 at 21:36):

alexcrichton requested dicej for a review on PR #9944.

Wasmtime GitHub notifications bot (Jan 07 2025 at 21:36):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9944.

Wasmtime GitHub notifications bot (Jan 07 2025 at 21:36):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9944.

Wasmtime GitHub notifications bot (Jan 07 2025 at 21:52):

dicej submitted PR review:

I'm new to Pulley and don't have much context for this, but LGTM. I'll leave it for someone with more experience to to approve.

Wasmtime GitHub notifications bot (Jan 08 2025 at 01:04):

github-actions[bot] commented on PR #9944:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "pulley"

Thus the following users have been cc'd because of the following labels:

• fitzgen: pulley

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jan 09 2025 at 16:36):

cfallin submitted PR review:

LGTM!

Wasmtime GitHub notifications bot (Jan 09 2025 at 16:37):

cfallin created PR review comment:

maybe a style thing, or Verilog influence, or something, but usually I write a:b concat syntax MSB-first (as the concrete values would be written) -- so dst_hi:dst_lo = ... maybe?

Wasmtime GitHub notifications bot (Jan 09 2025 at 16:48):

alexcrichton updated PR #9944.

Wasmtime GitHub notifications bot (Jan 09 2025 at 16:48):

alexcrichton has enabled auto merge for PR #9944.

Wasmtime GitHub notifications bot (Jan 09 2025 at 16:49):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jan 09 2025 at 16:49):

alexcrichton created PR review comment:

It's ok I have no influence so I think I swap lo:hi every time I write it, happy to canonicalize to hi:lo!

Wasmtime GitHub notifications bot (Jan 09 2025 at 17:18):

alexcrichton merged PR #9944.

Last updated: Jan 24 2025 at 00:11 UTC