Wasmtime GitHub notifications bot (Jan 06 2025 at 21:19): Wasmtime GitHub notifications bot (Jan 06 2025 at 21:19):alexcrichton opened PR #9937 from alexcrichton:enable-memory64 to bytecodealliance:main:
The memory64 proposal for WebAssembly moved to phase 4 early last November which was the final remaining blocker for enabling it in Wasmtime. I've gone ahead and enabled it here with all the other checkboxes being ticked such as:
Tests - all spec tests are enabled and we have a few tests here and there for memory64 behavior throughout the unit test suite.
Finished - this proposal's memory-facing bits have been done for quite some time and the final 64-bit table bits have been done for a bit now as well.
Fuzzed - this is enabled in
wasm-smithand additionally has custom fuzzing via thememory_accessesfuzzer.API - all APIs related to memory work with
u64values to accommodate 64-bit memories and the 64-bit-ness is reflected in the type of memories.C API - the C API's functions for working with memories all reflect 64-bit indices like the Rust API.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jan 06 2025 at 21:19):alexcrichton requested fitzgen for a review on PR #9937.
Wasmtime GitHub notifications bot (Jan 06 2025 at 21:19):alexcrichton requested wasmtime-core-reviewers for a review on PR #9937.
Wasmtime GitHub notifications bot (Jan 06 2025 at 21:19):alexcrichton requested wasmtime-default-reviewers for a review on PR #9937.
Wasmtime GitHub notifications bot (Jan 06 2025 at 23:45):github-actions[bot] commented on PR #9937:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
Wasmtime GitHub notifications bot (Jan 08 2025 at 15:18):dicej submitted PR review:
LGTM. Do we need to do anything special (that hasn't already been done) to indicate that memory64 is not yet compatible with components? Or will that be caught by
wasmparserat validation time?
Wasmtime GitHub notifications bot (Jan 08 2025 at 15:47):alexcrichton commented on PR #9937:
Oh you know that's a good point. I haven't checked up on the state of memory64 and components in awhile. I know some parts support some things but not all, and I suspect that there are a number of memory64-related panics in Wasmtime which I should convert to errors first before landing this.
Wasmtime GitHub notifications bot (Jan 08 2025 at 16:22):alexcrichton commented on PR #9937:
On review looks like less has support for this than I thought. I've opted to go with a wasmparser validation change for now since components don't currently specify how everything works anyway.
Wasmtime GitHub notifications bot (Jan 09 2025 at 00:07):alexcrichton commented on PR #9937:
I'm going to flag this for merging now that wasmparser has been updated and components reject memory64-based memories explicitly.
Wasmtime GitHub notifications bot (Jan 09 2025 at 00:26):alexcrichton merged PR #9937.
Last updated: Jan 24 2025 at 00:11 UTC