Stream: git-wasmtime

Topic: wasmtime / PR #9913 Fix incorrect frame code offset in co...

Wasmtime GitHub notifications bot (Dec 29 2024 at 20:40):

xtuc opened PR #9913 from xtuc:sven/coredump-relative-code-offset to bytecodealliance:main:

Currently, coredump include incorrect code offsets, the generation relies on func_offset() which returns the instruction's offset relative to the function.

This change uses module_offset() to get the absolute code offset and, using a new method get_relative_codeoffset, converts the offset to be relative to the code section.

Also, the name property has been removed because it's misleading when displayed and not actually useful.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 29 2024 at 20:40):

xtuc requested dicej for a review on PR #9913.

Wasmtime GitHub notifications bot (Dec 29 2024 at 20:40):

xtuc requested wasmtime-core-reviewers for a review on PR #9913.

Wasmtime GitHub notifications bot (Dec 29 2024 at 20:46):

xtuc closed without merge PR #9913.

Wasmtime GitHub notifications bot (Dec 29 2024 at 20:46):

xtuc commented on PR #9913:

Sorry seems like I misremembered https://github.com/WebAssembly/tool-conventions/blob/main/Coredump.md#threads-and-stack-frames... Code offsets are relative to the function start. Closing this since it's already correct.

Wasmtime GitHub notifications bot (Dec 29 2024 at 20:46):

xtuc edited a comment on PR #9913:

Sorry seems like I misremembered https://github.com/WebAssembly/tool-conventions/blob/main/Coredump.md#threads-and-stack-frames... Code offsets are relative to the function start. Closing this since it's correct as is.

Last updated: Jan 24 2025 at 00:11 UTC