Stream: git-wasmtime

Topic: wasmtime / PR #9906 fix typo

Wasmtime GitHub notifications bot (Dec 27 2024 at 13:35):

JackDrogon opened PR #9906 from JackDrogon:hotfix/fix_typo to bytecodealliance:main:

fix typo

Wasmtime GitHub notifications bot (Dec 27 2024 at 13:35):

JackDrogon requested cfallin for a review on PR #9906.

Wasmtime GitHub notifications bot (Dec 27 2024 at 13:35):

JackDrogon requested wasmtime-compiler-reviewers for a review on PR #9906.

Wasmtime GitHub notifications bot (Dec 27 2024 at 13:35):

JackDrogon requested wasmtime-core-reviewers for a review on PR #9906.

Wasmtime GitHub notifications bot (Dec 27 2024 at 13:35):

JackDrogon requested pchickey for a review on PR #9906.

Wasmtime GitHub notifications bot (Dec 27 2024 at 14:44):

github-actions[bot] commented on PR #9906:

Subscribe to Label Action

cc @cfallin, @fitzgen, @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle", "wasmtime:api", "wasmtime:config", "winch"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle
• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Dec 27 2024 at 15:44):

github-actions[bot] commented on PR #9906:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Dec 27 2024 at 17:02):

pchickey submitted PR review:

Thanks. Do you have automation that finds these, and if so, how many false positives did you filter out? We could stand to add something like that to CI if it’s not going to flag too many false positives.

Wasmtime GitHub notifications bot (Dec 27 2024 at 17:20):

pchickey merged PR #9906.

Wasmtime GitHub notifications bot (Dec 30 2024 at 01:52):

JackDrogon commented on PR #9906:

Thanks. Do you have automation that finds these, and if so, how many false positives did you filter out? We could stand to add something like that to CI if it’s not going to flag too many false positives.谢谢。您是否有自动功能来查找这些内容，如果有，您过滤掉了多少误报？如果 CI 不会标记太多误报，我们可以向 CI 添加类似的东西。

I use misspell and spellchecker to do this， only filter strate keyword of proptest and some typo in crates/wasi-nn/examples/.

Last updated: Jan 24 2025 at 00:11 UTC