Wasmtime GitHub notifications bot (Dec 27 2024 at 08:22): Wasmtime GitHub notifications bot (Dec 27 2024 at 08:22):eagr opened PR #9905 from eagr:isle-polish to bytecodealliance:main:
Basically just typo fixing and more succinct wording, without any intent to change the original meaning.
Wasmtime GitHub notifications bot (Dec 27 2024 at 08:22):eagr requested fitzgen for a review on PR #9905.
Wasmtime GitHub notifications bot (Dec 27 2024 at 08:22):eagr requested wasmtime-compiler-reviewers for a review on PR #9905.
Wasmtime GitHub notifications bot (Dec 27 2024 at 09:44):github-actions[bot] commented on PR #9905:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 27 2024 at 14:34):Couldn't seem to find the spec for
decl multiin the reference. Is it forgotten or like TBD?
Wasmtime GitHub notifications bot (Dec 27 2024 at 14:36):eagr edited a comment on PR #9905:
Couldn't seem to find the spec for
decl multiin the reference. Is it forgotten or like TBD? Does it mean something like "multifaceted" as in an item is both a constructor and extractor?
Wasmtime GitHub notifications bot (Dec 27 2024 at 18:53):cfallin submitted PR review:
Hi @eagr -- some comments below; I stopped reading after the last one, about 15% of the way through. Most of these edits are changing meaning in fairly important ways, and the ones that don't seem to be minor style things / subjective preferences, so I think I'd prefer not to accept an edit pass on this document -- given the magnitude of your changes I don't want to spend the time it would take to iterate back to fully correct wording. Thanks anyway, I'm sure you intended well. I'll go ahead and close this PR.
Wasmtime GitHub notifications bot (Dec 27 2024 at 18:53):cfallin created PR review comment:
This rewording is incorrect. "A ... pattern is a specification that a combination of operators ... can be compiled" can't be rewritten into "A ... pattern is a specification describing certain operators ... can be compiled". The first (current) form has a subordinate clause describing what the specification does, and the verb indicates that this specification can be compiled. Your rewrite somehow attaches two actions onto "specification" -- it describes, and it can be compiled. These aren't semantically equivalent.
Wasmtime GitHub notifications bot (Dec 27 2024 at 18:53):cfallin created PR review comment:
One cannot replace "properly" with "probably" -- that completely changes the meaning.
Wasmtime GitHub notifications bot (Dec 27 2024 at 18:53):cfallin created PR review comment:
This rewrite loses the meaning: the whole stanza is of the form "one could ... [but] ISLE lets you ..." and changing "could" to "can" completely changes the meaning.
Wasmtime GitHub notifications bot (Dec 27 2024 at 18:53):cfallin created PR review comment:
"an exact equivalent" does not read the same as "is exactly equal" to me: the former implies something about an equivalence class, different forms with the same underlying denotation, etc., whereas for primitive values (e.g. integers) we really do want to say "equal". I'm not sure what "equivalent" does better here.
Wasmtime GitHub notifications bot (Dec 27 2024 at 18:53):cfallin closed without merge PR #9905.
Last updated: Jan 24 2025 at 00:11 UTC