Stream: git-wasmtime

Topic: wasmtime / PR #9901 Stop formatting ISLE generated code

view this post on Zulip Wasmtime GitHub notifications bot (Dec 24 2024 at 19:06):

SingleAccretion opened PR #9901 from SingleAccretion:No-Fmt to bytecodealliance:main:

The tool stack overflows in default configurations (Windows/CI).

Example from a recent CI run: https://github.com/bytecodealliance/wasmtime/actions/runs/12472519540/job/34811457587?pr=9897.

Closes #9899.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 24 2024 at 19:06):

SingleAccretion edited PR #9901:

The tool stack overflows in default configurations (Windows/CI).

Example from a recent CI run: https://github.com/bytecodealliance/wasmtime/actions/runs/12472519540/job/34811457587?pr=9897:

warning: cranelift-codegen@0.116.0: Failed to run `rustfmt` on ISLE-generated code: Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }

Closes #9899.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 24 2024 at 19:14):

SingleAccretion edited PR #9901:

The tool stack overflows in default configurations (Windows on my machine (tm)/CI).

Example from a recent CI run: https://github.com/bytecodealliance/wasmtime/actions/runs/12472519540/job/34811457587?pr=9897:

warning: cranelift-codegen@0.116.0: Failed to run `rustfmt` on ISLE-generated code: Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }

Closes #9899.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 24 2024 at 19:14):

SingleAccretion edited PR #9901:

The tool stack overflows in default configurations (Windows on my machine (tm) / CI).

Example from a recent CI run: https://github.com/bytecodealliance/wasmtime/actions/runs/12472519540/job/34811457587?pr=9897:

warning: cranelift-codegen@0.116.0: Failed to run `rustfmt` on ISLE-generated code: Os { code: 32, kind: BrokenPipe, message: "Broken pipe" }

Closes #9899.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 24 2024 at 20:28):

SingleAccretion has marked PR #9901 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 24 2024 at 20:28):

SingleAccretion requested cfallin for a review on PR #9901.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 24 2024 at 20:28):

SingleAccretion requested wasmtime-compiler-reviewers for a review on PR #9901.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 26 2024 at 17:28):

cfallin submitted PR review:

Thanks!

Since the discussion on the bug I think I've realized why we had this to begin with: we were originally checking in the generated code to git (and updating when ISLE source changed), so this was likely load-bearing for passing CI formatting checks. Fortunately we don't do that anymore (ISLE-generated Rust is purely a build artifact) so we probably don't have any more reasons we'd want this back. Of course we can always revert if that changes.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 26 2024 at 17:48):

cfallin merged PR #9901.

Last updated: Jan 24 2025 at 00:11 UTC