Wasmtime GitHub notifications bot (Dec 22 2024 at 08:09): Wasmtime GitHub notifications bot (Dec 22 2024 at 08:09):ognevny opened PR #9891 from ognevny:update-cc to bytecodealliance:main:
this applies a fix for windows-gnullvm targets
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 22 2024 at 08:09):ognevny requested alexcrichton for a review on PR #9891.
Wasmtime GitHub notifications bot (Dec 22 2024 at 08:09):ognevny requested wasmtime-default-reviewers for a review on PR #9891.
Wasmtime GitHub notifications bot (Dec 22 2024 at 09:14):ognevny commented on PR #9891:
I don't understand CI failure :(
Wasmtime GitHub notifications bot (Dec 23 2024 at 16:48):alexcrichton commented on PR #9891:
Thanks for the PR! This is holiday season for a number of maintainers (including myself) so it'll be a week or two before I can review this at least. There's some more information about dependencies of wasmtime here if you're interested in the meantime though.
Wasmtime GitHub notifications bot (Jan 06 2025 at 15:53):alexcrichton updated PR #9891.
Wasmtime GitHub notifications bot (Jan 06 2025 at 15:54):alexcrichton commented on PR #9891:
The CI error here was because of the missing vet entries which maintainers manage as opposed to authors. I've added the vets here and once CI finishes this'll make its way to the merge queue. Thanks again for this!
Wasmtime GitHub notifications bot (Jan 06 2025 at 15:54):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Jan 06 2025 at 15:54):alexcrichton has enabled auto merge for PR #9891.
Wasmtime GitHub notifications bot (Jan 06 2025 at 15:54):ognevny commented on PR #9891:
thank you
Wasmtime GitHub notifications bot (Jan 06 2025 at 16:25):alexcrichton merged PR #9891.
Last updated: Jan 24 2025 at 00:11 UTC