Stream: git-wasmtime

Topic: wasmtime / PR #9885 Refactor release builds, add aarch64-...

Wasmtime GitHub notifications bot (Dec 20 2024 at 20:08):

alexcrichton opened PR #9885 from alexcrichton:aarch64-musl-build to bytecodealliance:main:

This commit refactors the way release builds are done in CI in terms of configuration and then additionally adds aarch64-musl release artifacts as requested in #9875. The refactoring here is done to reduce the number of locations to understand release builds. Notably the binary-compatible-builds action was removed in favor of direct environment configuration in conjunction with docker images used to build. The aarch64-musl build itself happens in a container provided by the cross project to ensure that the right toolchain is configured.

Closes #9875

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 20 2024 at 20:22):

alexcrichton updated PR #9885.

Wasmtime GitHub notifications bot (Dec 20 2024 at 20:39):

alexcrichton commented on PR #9885:

@whitequark from this CI page if you scroll to the bottom and find bins-aarch64-musl (here's a direct link, not sure if that'll work) can you test that out? Mostly just make sure ./wasmtime --help does something and maybe poke at the commands a bit. If that works I think this is probably good to go to eventually get integrated into wasmtime-py

Wasmtime GitHub notifications bot (Dec 20 2024 at 21:02):

whitequark commented on PR #9885:

OK so here is what I get if I run wasmtime in alpine edge on aarch64:

Wasmtime GitHub notifications bot (Dec 20 2024 at 21:07):

whitequark commented on PR #9885:

I think this might be Alpine-specific, for some reason libgcc isn't installed by default? Anyway, after I fixed that, it ran and executed a real Wasm application (nextpnr).

Wasmtime GitHub notifications bot (Dec 20 2024 at 21:15):

alexcrichton commented on PR #9885:

Ok perfect, thanks! I still don't know how to best manage libgcc_s on musl but it's at least no worse-off than the x64 target which I believe has the same behavior.

Wasmtime GitHub notifications bot (Dec 20 2024 at 21:15):

alexcrichton has marked PR #9885 as ready for review.

Wasmtime GitHub notifications bot (Dec 20 2024 at 21:15):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9885.

Wasmtime GitHub notifications bot (Dec 20 2024 at 21:15):

alexcrichton requested dicej for a review on PR #9885.

Wasmtime GitHub notifications bot (Dec 21 2024 at 18:43):

dicej submitted PR review.

Last updated: Dec 23 2024 at 12:05 UTC