Stream: git-wasmtime

Topic: wasmtime / PR #9883 Fix build on 32-bit Windows; consolid...

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:27):

alexcrichton opened PR #9883 from alexcrichton:fix-windows32 to bytecodealliance:main:

This commit fixes the build of the wasmtime crate and CLI on 32-bit Windows. This required adding some extra bits for trap handling and a stub for "unimplemented" for unwind information registration. This then additionally refactored our CI configuration to place all of the cross-compile checks in one matrix instead of spread out across a few jobs.

Closes #9882

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:27):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9883.

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:27):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9883.

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:27):

alexcrichton requested pchickey for a review on PR #9883.

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:29):

alexcrichton updated PR #9883.

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:29):

alexcrichton updated PR #9883.

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:37):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:38):

alexisvincent commented on PR #9883:

Fixes all except:

error[E0432]: unresolved import `crate::runtime::vm::HostAlignedByteCount`
 --> /xxx/wasmtime/crates/wasmtime/src/runtime/vm/sys/windows/mmap.rs:3:26
  |
3 | use crate::runtime::vm::{HostAlignedByteCount, SendSyncPtr};
  |                          ^^^^^^^^^^^^^^^^^^^^ no `HostAlignedByteCount` in `runtime::vm`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `wasmtime` (lib) due to 1 previous error

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:39):

alexisvincent edited a comment on PR #9883:

Fixes all except:

error[E0432]: unresolved import `crate::runtime::vm::HostAlignedByteCount`
 --> /xxx/wasmtime/crates/wasmtime/src/runtime/vm/sys/windows/mmap.rs:3:26
  |
3 | use crate::runtime::vm::{HostAlignedByteCount, SendSyncPtr};
  |                          ^^^^^^^^^^^^^^^^^^^^ no `HostAlignedByteCount` in `runtime::vm`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `wasmtime` (lib) due to 1 previous error

pulling wasmtime in transitively and compiling on macos. So possible issue is there.

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:41):

alexisvincent edited a comment on PR #9883:

Fixes all except:

error[E0432]: unresolved import `crate::runtime::vm::HostAlignedByteCount`
 --> /xxx/wasmtime/crates/wasmtime/src/runtime/vm/sys/windows/mmap.rs:3:26
  |
3 | use crate::runtime::vm::{HostAlignedByteCount, SendSyncPtr};
  |                          ^^^^^^^^^^^^^^^^^^^^ no `HostAlignedByteCount` in `runtime::vm`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `wasmtime` (lib) due to 1 previous error

pulling wasmtime in transitively and compiling on macos with i686-pc-windows-gnu. So possible issue is there.

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:43):

alexcrichton commented on PR #9883:

@alexisvincent I'm having a tough time reproducing that locally and I'm not sure why... Can you share what the dependency directive in Cargo.toml looks like for wasmtime? (unsure which features you have active)

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:45):

alexisvincent commented on PR #9883:

@alexisvincent I'm having a tough time reproducing that locally and I'm not sure why... Can you share what the dependency directive in Cargo.toml looks like for wasmtime? (unsure which features you have active)

Get it for --target=i686-pc-windows-gnu:

[dependencies.wasmtime]
path = "../../vendor/wasmtime/crates/wasmtime"
default-features = false
features = [
  "runtime"
]

Ill see if I can get a repro

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:46):

alexcrichton commented on PR #9883:

Ah no yep that works, thanks! I tried every combo but that, don't know why I didn't try the most obvious combo to start...

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:49):

alexcrichton updated PR #9883.

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:50):

alexcrichton has enabled auto merge for PR #9883.

Wasmtime GitHub notifications bot (Dec 20 2024 at 17:56):

alexcrichton edited PR #9883:

This commit fixes the build of the wasmtime crate and CLI on 32-bit Windows. This required adding some extra bits for trap handling and a stub for "unimplemented" for unwind information registration. This then additionally refactored our CI configuration to place all of the cross-compile checks in one matrix instead of spread out across a few jobs.

Closes #4434
Closes #9882

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 20 2024 at 18:21):

alexcrichton merged PR #9883.

Last updated: Dec 23 2024 at 12:05 UTC