Stream: git-wasmtime

Topic: wasmtime / PR #9870 pulley: Fix mistakes in compare-with-...

Wasmtime GitHub notifications bot (Dec 19 2024 at 21:14):

alexcrichton opened PR #9870 from alexcrichton:pulley-fix-compare-with-cond to bytecodealliance:main:

This commit fixes a few mistakes that were introduced in #9863. Specifically when lowering Cond.If... and the arguments needed swapping the condition was also inverted by accident. More *.clif runtests were added to catch this case and expose it. Additionally Pulley now has lowering for all the FloatCC orderings to be able to run the select.clif runtest which primarily exposed the issue.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 19 2024 at 21:14):

alexcrichton requested abrown for a review on PR #9870.

Wasmtime GitHub notifications bot (Dec 19 2024 at 21:14):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9870.

Wasmtime GitHub notifications bot (Dec 20 2024 at 01:30):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 20 2024 at 02:17):

fitzgen merged PR #9870.

Last updated: Dec 23 2024 at 12:05 UTC