Stream: git-wasmtime

Topic: wasmtime / PR #9862 pulley: Remove unwind metadata from C...

Wasmtime GitHub notifications bot (Dec 18 2024 at 23:54):

alexcrichton opened PR #9862 from alexcrichton:remove-pulley-unwind-info to bytecodealliance:main:

This is a copy/paste from the riscv64 backend originally but there's no need to integrate with native unwinders on Pulley so there's no need to track this information. This removes the Unwind pseudo-inst entirely.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 18 2024 at 23:54):

alexcrichton requested cfallin for a review on PR #9862.

Wasmtime GitHub notifications bot (Dec 18 2024 at 23:54):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9862.

Wasmtime GitHub notifications bot (Dec 19 2024 at 00:11):

cfallin submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Dec 19 2024 at 00:11):

cfallin created PR review comment:

strange artifact not caught by rustfmt maybe? would prefer isa::self to isa::{self}

Wasmtime GitHub notifications bot (Dec 19 2024 at 00:11):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 19 2024 at 01:36):

alexcrichton updated PR #9862.

Wasmtime GitHub notifications bot (Dec 19 2024 at 01:36):

alexcrichton created PR review comment:

oh oops I totally didn't notice this at all!

Wasmtime GitHub notifications bot (Dec 19 2024 at 01:36):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 19 2024 at 01:36):

alexcrichton has enabled auto merge for PR #9862.

Wasmtime GitHub notifications bot (Dec 19 2024 at 02:06):

alexcrichton merged PR #9862.

Last updated: Dec 23 2024 at 12:05 UTC