Stream: git-wasmtime

Topic: wasmtime / PR #9861 pulley: Add immediate payloads to mor...

Wasmtime GitHub notifications bot (Dec 18 2024 at 23:35):

alexcrichton opened PR #9861 from alexcrichton:pulley-more-immediates to bytecodealliance:main:

This commit adds immediate payloads to the following instructions:

• xmul32 - xmul32_s8 / xmul32_s32
• xmul64 - xmul64_s8 / xmul64_s32
• xband32 - xband32_s8 / xband32_s32
• xband64 - xband64_s8 / xband64_s32
• xbor32 - xbor32_s8 / xbor32_s32
• xbor64 - xbor64_s8 / xbor64_s32
• xbxor32 - xbxor32_s8 / xbxor32_s32
• xbxor64 - xbxor64_s8 / xbxor64_s32
• xshl32 - xshl32_u6
• xshl64 - xshl64_u6
• xshr32_u - xshl32_u_u6
• xshr64_u - xshl64_u_u6
• xshr32_s - xshl32_s_u6
• xshr64_s - xshl64_s_u6

For shifts there's no need to have 32-bit immediates (or even 8-bit) since 6 bits is enough to encode all the immediates. This means that the 6-bit immediate is packed within BinaryOperands as a new U6 type.

This commit unfortunately does not shrink spidermonkey.cwasm significantly beyond the prior 29M. This is nevertheless expected to be relatively important for performance.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 18 2024 at 23:35):

alexcrichton requested abrown for a review on PR #9861.

Wasmtime GitHub notifications bot (Dec 18 2024 at 23:35):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9861.

Wasmtime GitHub notifications bot (Dec 18 2024 at 23:35):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9861.

Wasmtime GitHub notifications bot (Dec 19 2024 at 01:05):

github-actions[bot] commented on PR #9861:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "isle", "pulley"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle, pulley

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Dec 19 2024 at 01:54):

fitzgen submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Dec 19 2024 at 02:13):

alexcrichton updated PR #9861.

Wasmtime GitHub notifications bot (Dec 19 2024 at 02:13):

alexcrichton has enabled auto merge for PR #9861.

Wasmtime GitHub notifications bot (Dec 19 2024 at 02:42):

alexcrichton merged PR #9861.

Last updated: Dec 23 2024 at 13:07 UTC