Wasmtime GitHub notifications bot (Dec 16 2024 at 17:07): Wasmtime GitHub notifications bot (Dec 16 2024 at 17:07):alexcrichton opened PR #9834 from alexcrichton:pulley-return-call to bytecodealliance:main:
This commit fleshes out the Cranelift lowerings of tail calls which gets the wasm tail call proposal itself working on Pulley. Most of the bits and pieces here were copied over from the riscv64 backend and then edited to suit Pulley.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 16 2024 at 17:07):alexcrichton requested fitzgen for a review on PR #9834.
Wasmtime GitHub notifications bot (Dec 16 2024 at 17:07):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9834.
Wasmtime GitHub notifications bot (Dec 16 2024 at 17:07):alexcrichton requested wasmtime-core-reviewers for a review on PR #9834.
Wasmtime GitHub notifications bot (Dec 16 2024 at 17:07):alexcrichton requested wasmtime-default-reviewers for a review on PR #9834.
Wasmtime GitHub notifications bot (Dec 16 2024 at 17:07):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Dec 16 2024 at 17:07):alexcrichton created PR review comment:
I wasn't sure how best to handle this, basically the test takes forever on an unoptimized interpreter (aka
cargo test) so I turned this down to be more reasonable, but that means this probably isn't testing what it originally wanted to test since the number is significantly smaller.
Wasmtime GitHub notifications bot (Dec 16 2024 at 17:41):alexcrichton updated PR #9834.
Wasmtime GitHub notifications bot (Dec 16 2024 at 18:48):github-actions[bot] commented on PR #9834:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle", "pulley", "wasmtime:api", "wasmtime:config"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle, pulley
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 16 2024 at 19:45):github-actions[bot] commented on PR #9834:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
Wasmtime GitHub notifications bot (Dec 16 2024 at 20:19):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Dec 16 2024 at 20:19):fitzgen created PR review comment:
I think this is probably fine as-is, since 100,000 is still pretty big, but we could add an import like
(import "env" "tail-recursion-count" (func (result i32))and configure it appropriately in the wast utils crate.
Wasmtime GitHub notifications bot (Dec 16 2024 at 20:19):fitzgen edited PR review comment.
Wasmtime GitHub notifications bot (Dec 16 2024 at 20:26):fitzgen submitted PR review:
:+1:
Wasmtime GitHub notifications bot (Dec 16 2024 at 20:51):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Dec 16 2024 at 20:51):alexcrichton created PR review comment:
I'm a bit wary to extend the namespace of builtins just yet so I'm follow your gut and leave this at 100k for now. We might want a little more "official-ness" around extending the set of names
wastcan import by default than a one-off thing such as this.
Wasmtime GitHub notifications bot (Dec 16 2024 at 21:10):alexcrichton merged PR #9834.
Last updated: Dec 23 2024 at 12:05 UTC