Wasmtime GitHub notifications bot (Dec 16 2024 at 15:34): Wasmtime GitHub notifications bot (Dec 16 2024 at 15:34):alexcrichton opened PR #9832 from alexcrichton:simd-splat to bytecodealliance:main:
Gets a few spec tests and CLIF tests passing
cc #9783
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 16 2024 at 15:34):alexcrichton requested abrown for a review on PR #9832.
Wasmtime GitHub notifications bot (Dec 16 2024 at 15:34):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9832.
Wasmtime GitHub notifications bot (Dec 16 2024 at 15:34):alexcrichton requested wasmtime-core-reviewers for a review on PR #9832.
Wasmtime GitHub notifications bot (Dec 16 2024 at 15:34):alexcrichton requested dicej for a review on PR #9832.
Wasmtime GitHub notifications bot (Dec 16 2024 at 15:34):alexcrichton requested wasmtime-default-reviewers for a review on PR #9832.
Wasmtime GitHub notifications bot (Dec 16 2024 at 16:48):github-actions[bot] commented on PR #9832:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "pulley"Thus the following users have been cc'd because of the following labels:
- fitzgen: pulley
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 17 2024 at 00:21):abrown submitted PR review:
LGTM!
Wasmtime GitHub notifications bot (Dec 17 2024 at 00:21):abrown created PR review comment:
;;;; Rules for `splat` ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
Wasmtime GitHub notifications bot (Dec 17 2024 at 00:21):abrown created PR review comment:
...just mulling over whether discarding the upper bits here is going to be problematic — probably not?
Wasmtime GitHub notifications bot (Dec 17 2024 at 00:21):abrown created PR review comment:
We may need
get_u8andget_u16eventually?
Wasmtime GitHub notifications bot (Dec 17 2024 at 00:26):alexcrichton updated PR #9832.
Wasmtime GitHub notifications bot (Dec 17 2024 at 00:26):alexcrichton has enabled auto merge for PR #9832.
Wasmtime GitHub notifications bot (Dec 17 2024 at 00:27):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Dec 17 2024 at 00:27):alexcrichton created PR review comment:
I've been wondering the same yeah, I'll probably add these in a follow-up
Wasmtime GitHub notifications bot (Dec 17 2024 at 01:03):alexcrichton merged PR #9832.
Last updated: Dec 23 2024 at 12:05 UTC