Wasmtime GitHub notifications bot (Dec 14 2024 at 22:49): Wasmtime GitHub notifications bot (Dec 14 2024 at 22:49):alexcrichton opened PR #9825 from alexcrichton:pulley-more-clif-tests to bytecodealliance:main:
This commit adds the pulley targets to many of the preexisting
*.clifruntests throughout the tree. This covers most of the MVP functionality of wasm for example and additionally exercises 8 and 16-bit lowerings for many instructions. A few minor pulley instructions were added and otherwise new 8/16-bit lowerings use existing instructions. It's expected that the 8/16-bit lowerings won't be used all that often so they're not particularly optimal at this time.Some CLIF tests were omitted such as:
- Most SIMD-using CLIF tests
- Float/int conversion tests using 8 and 16-bit integers
- Tests with
callinstructions as relocations don't work with the JIT crate on Pulley- Tests using 128-bit integers
Support for some of these tests may be enabled in the future, but for example 8/16-bit integers may not get used much.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 14 2024 at 22:49):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9825.
Wasmtime GitHub notifications bot (Dec 14 2024 at 22:49):alexcrichton requested abrown for a review on PR #9825.
Wasmtime GitHub notifications bot (Dec 14 2024 at 22:49):alexcrichton requested wasmtime-default-reviewers for a review on PR #9825.
Wasmtime GitHub notifications bot (Dec 15 2024 at 18:32):alexcrichton updated PR #9825.
Wasmtime GitHub notifications bot (Dec 16 2024 at 12:21):fitzgen submitted PR review:
Very nice
Wasmtime GitHub notifications bot (Dec 16 2024 at 12:41):fitzgen merged PR #9825.
Last updated: Dec 23 2024 at 12:05 UTC