Wasmtime GitHub notifications bot (Dec 13 2024 at 21:07): Wasmtime GitHub notifications bot (Dec 13 2024 at 21:07):alexcrichton opened PR #9820 from alexcrichton:pulley-simd to bytecodealliance:main:
This commit fills out some of the initial infrastructure necessary for
supporting the SIMD proposal to WebAssembly in the Pulley interpreter,
namely 128-bit simd. TheVRegValunion has been filled out with
various types, endianness questions are settled, and initial
implementations of a suite of opcodes are added to get a basic set of
tests working throughout the backend.
Wasmtime GitHub notifications bot (Dec 13 2024 at 21:07):alexcrichton requested cfallin for a review on PR #9820.
Wasmtime GitHub notifications bot (Dec 13 2024 at 21:07):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9820.
Wasmtime GitHub notifications bot (Dec 13 2024 at 21:07):alexcrichton requested wasmtime-core-reviewers for a review on PR #9820.
Wasmtime GitHub notifications bot (Dec 13 2024 at 21:07):alexcrichton requested fitzgen for a review on PR #9820.
Wasmtime GitHub notifications bot (Dec 13 2024 at 21:07):alexcrichton requested wasmtime-default-reviewers for a review on PR #9820.
Wasmtime GitHub notifications bot (Dec 13 2024 at 21:08):alexcrichton commented on PR #9820:
based on https://github.com/bytecodealliance/wasmtime/pull/9819, https://github.com/bytecodealliance/wasmtime/pull/9817 (approved and waiting on CI), and https://github.com/bytecodealliance/wasmtime/pull/9815 (approved and waiting on CI)
Wasmtime GitHub notifications bot (Dec 13 2024 at 22:03):alexcrichton updated PR #9820.
Wasmtime GitHub notifications bot (Dec 13 2024 at 22:04):alexcrichton edited a comment on PR #9820:
based on https://github.com/bytecodealliance/wasmtime/pull/9819,
https://github.com/bytecodealliance/wasmtime/pull/9817 (approved and waiting on CI), and https://github.com/bytecodealliance/wasmtime/pull/9815 (approved and waiting on CI)
Wasmtime GitHub notifications bot (Dec 13 2024 at 23:44):github-actions[bot] commented on PR #9820:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "pulley"Thus the following users have been cc'd because of the following labels:
- fitzgen: pulley
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 14 2024 at 00:20):fitzgen submitted PR review:
Very nice
Wasmtime GitHub notifications bot (Dec 14 2024 at 00:35):alexcrichton updated PR #9820.
Wasmtime GitHub notifications bot (Dec 14 2024 at 00:35):alexcrichton has enabled auto merge for PR #9820.
Wasmtime GitHub notifications bot (Dec 14 2024 at 01:23):alexcrichton updated PR #9820.
Wasmtime GitHub notifications bot (Dec 14 2024 at 01:23):alexcrichton updated PR #9820.
Wasmtime GitHub notifications bot (Dec 14 2024 at 01:23):alexcrichton requested fitzgen for a review on PR #9820.
Wasmtime GitHub notifications bot (Dec 14 2024 at 01:24):alexcrichton commented on PR #9820:
@fitzgen if you wouldn't mind taking a look at the second commit here. The CI failure was due to endianness failures on s390x because big-endian loads/stores of vectors aren't implemented in Pulley. I personally find it easiest to sidestep the question entirely, so I've redefined wasm globals to be little-endian instead of big-endian, updated some accessors, and then additionally updated pulley stack loads/stores of vectors to be in little-endian.
I also needed to implement
bitcastfor an s390x test which got a few more wast tests passing.
Wasmtime GitHub notifications bot (Dec 14 2024 at 02:24):alexcrichton updated PR #9820.
Wasmtime GitHub notifications bot (Dec 14 2024 at 20:51):fitzgen submitted PR review:
SGTM
Wasmtime GitHub notifications bot (Dec 14 2024 at 22:49):alexcrichton merged PR #9820.
Last updated: Dec 23 2024 at 13:07 UTC