Stream: git-wasmtime

Topic: wasmtime / PR #9810 pulley: Implement fcopysign for issue...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 20:50):

minirop opened PR #9810 from minirop:pulley-fcopysign to bytecodealliance:main:

I made test issue4890.wast pass by handling fcopysign.

cc #9783

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 20:50):

minirop requested wasmtime-compiler-reviewers for a review on PR #9810.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 20:50):

minirop requested abrown for a review on PR #9810.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 20:50):

minirop requested wasmtime-default-reviewers for a review on PR #9810.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 21:04):

alexcrichton commented on PR #9810:

Thanks for this! To get past CI I think you'll need two minor changes as well:

  1. Update crates/wast-util/src/lib.rs to flag the test as now-passing.
  2. Update pulley/src/interp/float_ext.rs to have a #![no_std] implementation of copysign. For that you should be able to use libm::copysign and libm::copysignf

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 21:04):

alexcrichton requested alexcrichton for a review on PR #9810.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 21:05):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 21:05):

alexcrichton created PR review comment:

Ah as another comment, mind using operands: BinaryOperands<FReg> here? That'll match how other binops work and make this a bit more compact. Additionally mind updating the docs here? (looks copy/pasted from elsewhere)

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 21:36):

minirop requested wasmtime-core-reviewers for a review on PR #9810.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 21:36):

minirop requested dicej for a review on PR #9810.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 21:36):

minirop updated PR #9810.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 21:45):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 21:45):

alexcrichton has enabled auto merge for PR #9810.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 22:09):

alexcrichton merged PR #9810.

Last updated: Dec 23 2024 at 13:07 UTC