Wasmtime GitHub notifications bot (Dec 12 2024 at 20:07): Wasmtime GitHub notifications bot (Dec 12 2024 at 20:07):alexcrichton requested fitzgen for a review on PR #9808.
Wasmtime GitHub notifications bot (Dec 12 2024 at 20:07):alexcrichton opened PR #9808 from alexcrichton:pulley-float-ops to bytecodealliance:main:
Fill out enough to get
f32.wastandf64.wastspec tests working. A minor ABI issue was discovered along the way which is also required to get a new test working on both 32 and 64-bit platforms.cc #9783
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 12 2024 at 20:07):alexcrichton requested wasmtime-core-reviewers for a review on PR #9808.
Wasmtime GitHub notifications bot (Dec 12 2024 at 20:07):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9808.
Wasmtime GitHub notifications bot (Dec 12 2024 at 20:07):alexcrichton requested wasmtime-default-reviewers for a review on PR #9808.
Wasmtime GitHub notifications bot (Dec 12 2024 at 20:23):alexcrichton updated PR #9808.
Wasmtime GitHub notifications bot (Dec 12 2024 at 21:44):github-actions[bot] commented on PR #9808:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta", "pulley", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- fitzgen: pulley
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 12 2024 at 22:19):alexcrichton updated PR #9808.
Wasmtime GitHub notifications bot (Dec 13 2024 at 13:43):fitzgen submitted PR review:
Nice
Wasmtime GitHub notifications bot (Dec 13 2024 at 16:50):alexcrichton updated PR #9808.
Wasmtime GitHub notifications bot (Dec 13 2024 at 16:50):alexcrichton requested fitzgen for a review on PR #9808.
Wasmtime GitHub notifications bot (Dec 13 2024 at 16:51):alexcrichton commented on PR #9808:
@fitzgen mind reviewing the last commit? Turns out
a.trunc()differs on MSVC and Linux (e.g. glibc) so I've extracted all the logic to a new crate to share between the runtime libcalls and Pulley. In theory should have been done already but it was getting complicated enough now that it was definitely worth it I think.
Wasmtime GitHub notifications bot (Dec 13 2024 at 16:52):alexcrichton updated PR #9808.
Wasmtime GitHub notifications bot (Dec 13 2024 at 16:57):alexcrichton updated PR #9808.
Wasmtime GitHub notifications bot (Dec 13 2024 at 16:57):alexcrichton updated PR #9808.
Wasmtime GitHub notifications bot (Dec 13 2024 at 17:06):alexcrichton updated PR #9808.
Wasmtime GitHub notifications bot (Dec 13 2024 at 17:24):alexcrichton updated PR #9808.
Wasmtime GitHub notifications bot (Dec 13 2024 at 17:49):fitzgen submitted PR review:
New commit looks good to me :+1:
Wasmtime GitHub notifications bot (Dec 13 2024 at 17:52):alexcrichton updated PR #9808.
Wasmtime GitHub notifications bot (Dec 13 2024 at 17:52):alexcrichton has enabled auto merge for PR #9808.
Wasmtime GitHub notifications bot (Dec 13 2024 at 18:25):alexcrichton merged PR #9808.
Last updated: Dec 23 2024 at 13:07 UTC