Stream: git-wasmtime

Topic: wasmtime / PR #9806 pulley: Move `fp`/`lr` out of `XReg` set

Wasmtime GitHub notifications bot (Dec 12 2024 at 17:58):

alexcrichton opened PR #9806 from alexcrichton:pulley-more-gpr to bytecodealliance:main:

This commit moves the fp and lr registers out of the XReg register set and into the MachineState per-VM. These are automatically modified and read with push_frame and pop_frame. Dedicated xmov_{fp,lr} instructions were added for use in Wasmtime's trampolines which directly read these registers.

cc #9747

Wasmtime GitHub notifications bot (Dec 12 2024 at 17:58):

alexcrichton requested abrown for a review on PR #9806.

Wasmtime GitHub notifications bot (Dec 12 2024 at 17:58):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9806.

Wasmtime GitHub notifications bot (Dec 12 2024 at 17:58):

alexcrichton requested dicej for a review on PR #9806.

Wasmtime GitHub notifications bot (Dec 12 2024 at 17:58):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9806.

Wasmtime GitHub notifications bot (Dec 12 2024 at 17:58):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9806.

Wasmtime GitHub notifications bot (Dec 12 2024 at 17:59):

alexcrichton commented on PR #9806:

I'd like to get there with sp as well too but that'll require more special care since it's used in memory-related instructions as a base for stack loads/stores.

Wasmtime GitHub notifications bot (Dec 12 2024 at 18:01):

alexcrichton updated PR #9806.

Wasmtime GitHub notifications bot (Dec 12 2024 at 19:45):

github-actions[bot] commented on PR #9806:

Subscribe to Label Action

cc @cfallin, @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "isle", "pulley", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• cfallin: isle
• fitzgen: isle, pulley

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Dec 12 2024 at 20:40):

alexcrichton updated PR #9806.

Wasmtime GitHub notifications bot (Dec 13 2024 at 13:54):

fitzgen submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Dec 13 2024 at 13:54):

fitzgen created PR review comment:

Do we actually use spilltmp2 in pulley? AFAICT, we don't. Could free up one more GPR I think.

Wasmtime GitHub notifications bot (Dec 13 2024 at 13:55):

fitzgen edited PR review comment.

Wasmtime GitHub notifications bot (Dec 13 2024 at 16:54):

alexcrichton updated PR #9806.

Wasmtime GitHub notifications bot (Dec 13 2024 at 16:54):

alexcrichton has enabled auto merge for PR #9806.

Wasmtime GitHub notifications bot (Dec 13 2024 at 17:27):

alexcrichton merged PR #9806.

Last updated: Dec 23 2024 at 12:05 UTC