Stream: git-wasmtime

Topic: wasmtime / PR #9803 pulley: Fill out remaining 32/64-bit ...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:24):

alexcrichton opened PR #9803 from alexcrichton:pulley-int-ops to bytecodealliance:main:

This required some extra plumbing to shepherd the precise reason why
signed division trapped to Wasmtime which is done through an extra
TrapKind side channel now added.

This then additionally fixes the signed remainder interpreter function
to return 0 on MIN % -1 which is different from what Rust specifies
(which is to return None or panic).

cc https://github.com/bytecodealliance/wasmtime/issues/9783

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:24):

alexcrichton requested fitzgen for a review on PR #9803.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:24):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9803.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:24):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9803.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:24):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9803.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:24):

alexcrichton commented on PR #9803:

Note this is currently built on https://github.com/bytecodealliance/wasmtime/pull/9801

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:25):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:25):

alexcrichton created PR review comment:

I'll note that this is an interesting case of a divergence in Rust semantics and WebAssembly semantics.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:26):

alexcrichton updated PR #9803.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:31):

alexcrichton updated PR #9803.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:31):

alexcrichton has enabled auto merge for PR #9803.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:52):

alexcrichton updated PR #9803.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 16:52):

alexcrichton edited a comment on PR #9803:

~~Note this is currently built on https://github.com/bytecodealliance/wasmtime/pull/9801~~

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 18:27):

fitzgen submitted PR review:

:+1:

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 18:57):

alexcrichton updated PR #9803.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 18:57):

alexcrichton has enabled auto merge for PR #9803.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 12 2024 at 19:31):

alexcrichton merged PR #9803.

Last updated: Dec 23 2024 at 12:05 UTC