Stream: git-wasmtime

Topic: wasmtime / PR #9801 pulley: Get strings.wast test passing

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:26):

alexcrichton opened PR #9801 from alexcrichton:pulley-imul to bytecodealliance:main:

Needed the imul CLIF instruction to get implemented so 32/64-bit
multiplication have now been added.

cc https://github.com/bytecodealliance/wasmtime/issues/9783

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:26):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9801.

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:26):

alexcrichton requested fitzgen for a review on PR #9801.

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:26):

alexcrichton requested abrown for a review on PR #9801.

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:26):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9801.

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:26):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9801.

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:27):

alexcrichton commented on PR #9801:

Note that this is currently based on https://github.com/bytecodealliance/wasmtime/pull/9797

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:27):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:27):

alexcrichton created PR review comment:

This change was needed because otherwise we overran the recursion limit and rustc asked for a #![recursion_limit = "bigger"] value which I wanted to avoid so I switch this to using the final enum here instead.

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:56):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:57):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 12 2024 at 15:57):

fitzgen created PR review comment:

Might be an off by one here? Does this need a + 1?

Wasmtime GitHub notifications bot (Dec 12 2024 at 16:19):

alexcrichton updated PR #9801.

Wasmtime GitHub notifications bot (Dec 12 2024 at 16:19):

alexcrichton updated PR #9801.

Wasmtime GitHub notifications bot (Dec 12 2024 at 16:21):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 12 2024 at 16:21):

alexcrichton created PR review comment:

Double-checked, but this doesn't have the +1 for now. (it's at least the same as before)

Wasmtime GitHub notifications bot (Dec 12 2024 at 16:21):

alexcrichton has enabled auto merge for PR #9801.

Wasmtime GitHub notifications bot (Dec 12 2024 at 16:51):

alexcrichton merged PR #9801.

Last updated: Dec 23 2024 at 12:05 UTC