Wasmtime GitHub notifications bot (Dec 11 2024 at 15:38): Wasmtime GitHub notifications bot (Dec 11 2024 at 15:38):minirop opened PR #9787 from minirop:winch-convert-aarch64 to bytecodealliance:main:
Implement the following MASM instructions for the Aarch64 platform (#8321):
- signed_convert
- unsigned_convert
And fix mistakes introduced by #9767.
Wasmtime GitHub notifications bot (Dec 11 2024 at 15:38):minirop requested cfallin for a review on PR #9787.
Wasmtime GitHub notifications bot (Dec 11 2024 at 15:38):minirop requested wasmtime-compiler-reviewers for a review on PR #9787.
Wasmtime GitHub notifications bot (Dec 11 2024 at 15:38):minirop requested alexcrichton for a review on PR #9787.
Wasmtime GitHub notifications bot (Dec 11 2024 at 15:38):minirop requested wasmtime-core-reviewers for a review on PR #9787.
Wasmtime GitHub notifications bot (Dec 11 2024 at 17:28):cfallin requested saulecabrera for a review on PR #9787.
Wasmtime GitHub notifications bot (Dec 11 2024 at 19:06):saulecabrera submitted PR review:
Looks good to me, a few typos below.
Wasmtime GitHub notifications bot (Dec 11 2024 at 19:06):saulecabrera created PR review comment:
/// Convert an integer to a float.
Wasmtime GitHub notifications bot (Dec 11 2024 at 19:06):saulecabrera created PR review comment:
/// Convert a float to an integer.
Wasmtime GitHub notifications bot (Dec 11 2024 at 22:05):saulecabrera submitted PR review:
Oh my bad, I reviewed commit by commit and realized that in your second commit the documentation is fixed. Thanks!
Wasmtime GitHub notifications bot (Dec 11 2024 at 22:22):saulecabrera merged PR #9787.
Last updated: Dec 23 2024 at 12:05 UTC