Stream: git-wasmtime

Topic: wasmtime / PR #9785 pulley: Ungate the GC_TYPES feature ...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 15:29):

alexcrichton opened PR #9785 from alexcrichton:pulley-gc-types to bytecodealliance:main:

Similar to https://github.com/bytecodealliance/wasmtime/pull/9779 this remove the GC_TYPES feature from the list of
panicking features in Pulley. In doing so this then additionally fixes a
number of panics and then adds more tests that are working. Some other
minor instructions are filled out to ensure that tests are working on
both 32 and 64-bit platforms.

cc #9783

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 15:29):

alexcrichton requested abrown for a review on PR #9785.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 15:29):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9785.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 15:29):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9785.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 15:29):

alexcrichton requested fitzgen for a review on PR #9785.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 15:29):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9785.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 15:29):

alexcrichton commented on PR #9785:

Note this is currently based on #9780

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 15:57):

fitzgen created PR review comment:

This is a somewhat unfortunate instruction name :-/

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 15:57):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 16:10):

alexcrichton created PR review comment:

Heh good eye! I didn't even realize this until I added lowerings for bxor later and wrote pulley_xxor. In a future PR I'll rename this to pulley_xbor32 to make room for the actual xor op.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 16:10):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 16:14):

alexcrichton updated PR #9785.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 16:14):

alexcrichton has enabled auto merge for PR #9785.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 16:50):

alexcrichton merged PR #9785.

Last updated: Dec 23 2024 at 13:07 UTC