Wasmtime GitHub notifications bot (Dec 11 2024 at 15:28): Wasmtime GitHub notifications bot (Dec 11 2024 at 15:28):saulecabrera opened PR #9784 from saulecabrera:winch-arm64-fix-div-sign to bytecodealliance:main:
This commit fixes how signedness division is hanlded in aarch64. Prior to this commit, sign-extension was emitted unconditionally.
This commit ensures that the correct extension is emitted depending on the division kind.
Additionally this commit prefers making use of existing assembler helpers.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 11 2024 at 15:28):saulecabrera requested cfallin for a review on PR #9784.
Wasmtime GitHub notifications bot (Dec 11 2024 at 15:28):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #9784.
Wasmtime GitHub notifications bot (Dec 11 2024 at 15:28):saulecabrera requested fitzgen for a review on PR #9784.
Wasmtime GitHub notifications bot (Dec 11 2024 at 15:28):saulecabrera requested wasmtime-core-reviewers for a review on PR #9784.
Wasmtime GitHub notifications bot (Dec 11 2024 at 16:01):fitzgen submitted PR review:
:+1:
Wasmtime GitHub notifications bot (Dec 11 2024 at 16:21):saulecabrera merged PR #9784.
Last updated: Dec 23 2024 at 13:07 UTC