Stream: git-wasmtime

Topic: wasmtime / PR #9782 winch: relax some FnMut constraints

view this post on Zulip Wasmtime GitHub notifications bot (Dec 10 2024 at 23:37):

MarinPostma opened PR #9782 from MarinPostma:relax-uncessary-fnmut to bytecodealliance:main:

while working with the emit_binop operator, I found myself needed to derive copy and clone for some types, because the callback was FnMut. After inspection, the closure doesn't need to be FnMut, and FnOnce suffice. This is not much, but I think it improves the ergonomics slightly.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 10 2024 at 23:37):

MarinPostma requested fitzgen for a review on PR #9782.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 10 2024 at 23:37):

MarinPostma requested wasmtime-compiler-reviewers for a review on PR #9782.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 10 2024 at 23:58):

saulecabrera submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 11 2024 at 00:15):

saulecabrera merged PR #9782.

Last updated: Dec 23 2024 at 13:07 UTC