Wasmtime GitHub notifications bot (Dec 10 2024 at 18:32): Wasmtime GitHub notifications bot (Dec 10 2024 at 18:32):alexcrichton opened PR #9779 from alexcrichton:pulley-ungate-simd to bytecodealliance:main:
This commit removes the simd proposal from "known panicking compiler
features" for Pulley by filling out some minor ABI bits around
loads/stores of v128 in the Cranelift ABI code. This unlocks running
spec_testsuite/*.wastin CI and expecting it to pass as otherwise
everything was rejected since that test suite requires SIMD and it never
even got to the Cranelift backend.This then fixes a few minor issues here and there to get existing tests
passing now that they're actually being run. Some examples are:
Fix some copy/paste typos around callee-save clobbers and float
registers.Add vector load/store support to avoid panicking in ABI code (not well
tested yet though).Zero-extend the condition in
brif's lowering to ensure that the
entire register is defined. In the future more variants ofbr_ifin
Pulley are probably desired.Limit
storelowerings to just integer types, not vector types.- Fix
Func::callwith Pulley when the callee is a host function.
Wasmtime GitHub notifications bot (Dec 10 2024 at 18:32):alexcrichton requested fitzgen for a review on PR #9779.
Wasmtime GitHub notifications bot (Dec 10 2024 at 18:32):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9779.
Wasmtime GitHub notifications bot (Dec 10 2024 at 18:32):alexcrichton requested wasmtime-fuzz-reviewers for a review on PR #9779.
Wasmtime GitHub notifications bot (Dec 10 2024 at 18:32):alexcrichton requested wasmtime-core-reviewers for a review on PR #9779.
Wasmtime GitHub notifications bot (Dec 10 2024 at 18:32):alexcrichton requested wasmtime-default-reviewers for a review on PR #9779.
Wasmtime GitHub notifications bot (Dec 10 2024 at 18:32):alexcrichton commented on PR #9779:
Note that this is currently based on https://github.com/bytecodealliance/wasmtime/pull/9775
Wasmtime GitHub notifications bot (Dec 10 2024 at 18:58):alexcrichton updated PR #9779.
Wasmtime GitHub notifications bot (Dec 10 2024 at 18:59):alexcrichton edited a comment on PR #9779:
~~Note that this is currently based on https://github.com/bytecodealliance/wasmtime/pull/9775~~
Wasmtime GitHub notifications bot (Dec 10 2024 at 20:21):alexcrichton updated PR #9779.
Wasmtime GitHub notifications bot (Dec 10 2024 at 21:44):github-actions[bot] commented on PR #9779:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "pulley", "wasmtime:api", "wasmtime:config"Thus the following users have been cc'd because of the following labels:
- fitzgen: pulley
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 10 2024 at 22:45):github-actions[bot] commented on PR #9779:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
Wasmtime GitHub notifications bot (Dec 11 2024 at 12:26):fitzgen submitted PR review:
Nice
Wasmtime GitHub notifications bot (Dec 11 2024 at 12:44):fitzgen merged PR #9779.
Wasmtime GitHub notifications bot (Dec 11 2024 at 15:28):alexcrichton edited PR #9779:
This commit removes the simd proposal from "known panicking compiler
features" for Pulley by filling out some minor ABI bits around
loads/stores of v128 in the Cranelift ABI code. This unlocks running
spec_testsuite/*.wastin CI and expecting it to pass as otherwise
everything was rejected since that test suite requires SIMD and it never
even got to the Cranelift backend.This then fixes a few minor issues here and there to get existing tests
passing now that they're actually being run. Some examples are:
Fix some copy/paste typos around callee-save clobbers and float
registers.Add vector load/store support to avoid panicking in ABI code (not well
tested yet though).Zero-extend the condition in
brif's lowering to ensure that the
entire register is defined. In the future more variants ofbr_ifin
Pulley are probably desired.Limit
storelowerings to just integer types, not vector types.- Fix
Func::callwith Pulley when the callee is a host function.cc #9783
Last updated: Dec 23 2024 at 12:05 UTC