Wasmtime GitHub notifications bot (Dec 07 2024 at 19:22): Wasmtime GitHub notifications bot (Dec 07 2024 at 19:22):alexcrichton opened PR #9763 from alexcrichton:fix-off-by-one to bytecodealliance:main:
Fuzzing found a small issue with #9687 and this commit relaxes a few off-by-one checks to allow addressing one-byte-beyond-the-end of a linear memory.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 07 2024 at 19:22):alexcrichton requested fitzgen for a review on PR #9763.
Wasmtime GitHub notifications bot (Dec 07 2024 at 19:22):alexcrichton requested wasmtime-core-reviewers for a review on PR #9763.
Wasmtime GitHub notifications bot (Dec 07 2024 at 19:22):alexcrichton commented on PR #9763:
cc @sunshowers (you're likely interested, but this of course wasn't your fault)
Wasmtime GitHub notifications bot (Dec 07 2024 at 19:54):sunshowers submitted PR review.
Wasmtime GitHub notifications bot (Dec 07 2024 at 19:54):sunshowers created PR review comment:
Ahh thank you! Haha this comment anticipated it — needs to be changed.
Wasmtime GitHub notifications bot (Dec 07 2024 at 19:55):sunshowers submitted PR review.
Wasmtime GitHub notifications bot (Dec 07 2024 at 19:55):sunshowers created PR review comment:
This as well.
I really wasn't sure which one was correct—glad it got caught
Wasmtime GitHub notifications bot (Dec 09 2024 at 15:38):alexcrichton updated PR #9763.
Wasmtime GitHub notifications bot (Dec 10 2024 at 14:15):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Dec 10 2024 at 14:32):fitzgen merged PR #9763.
Last updated: Dec 23 2024 at 13:07 UTC