Stream: git-wasmtime

Topic: wasmtime / PR #9762 winch: implement div for aarch64

Wasmtime GitHub notifications bot (Dec 07 2024 at 15:48):

MarinPostma opened PR #9762 from MarinPostma:aarch-64-div to bytecodealliance:main:

Implement integer division for arch64

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 07 2024 at 15:51):

MarinPostma updated PR #9762.

Wasmtime GitHub notifications bot (Dec 07 2024 at 17:45):

github-actions[bot] commented on PR #9762:

Subscribe to Label Action

cc @saulecabrera

<details>
This issue or pull request has been labeled: "winch"

Thus the following users have been cc'd because of the following labels:

• saulecabrera: winch

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Dec 08 2024 at 11:19):

MarinPostma has marked PR #9762 as ready for review.

Wasmtime GitHub notifications bot (Dec 08 2024 at 11:19):

MarinPostma requested wasmtime-compiler-reviewers for a review on PR #9762.

Wasmtime GitHub notifications bot (Dec 08 2024 at 11:19):

MarinPostma requested cfallin for a review on PR #9762.

Wasmtime GitHub notifications bot (Dec 08 2024 at 11:19):

MarinPostma requested alexcrichton for a review on PR #9762.

Wasmtime GitHub notifications bot (Dec 08 2024 at 11:19):

MarinPostma requested wasmtime-core-reviewers for a review on PR #9762.

Wasmtime GitHub notifications bot (Dec 08 2024 at 20:07):

cfallin requested saulecabrera for a review on PR #9762.

Wasmtime GitHub notifications bot (Dec 08 2024 at 20:07):

cfallin commented on PR #9762:

passing review over to @saulecabrera if you don't mind!

Wasmtime GitHub notifications bot (Dec 09 2024 at 21:40):

saulecabrera submitted PR review:

Looks reasonable to me; a couple of nitpicks inline.

Wasmtime GitHub notifications bot (Dec 09 2024 at 21:40):

saulecabrera created PR review comment:

        // `cranelift-codegen` doesn't support emitting u/sdiv for anything but I64,

Wasmtime GitHub notifications bot (Dec 09 2024 at 21:40):

saulecabrera created PR review comment:

Here you can use the emit_alu_rrr helper defined in this file.

Wasmtime GitHub notifications bot (Dec 09 2024 at 21:40):

saulecabrera created PR review comment:

Would you mind linking to this issue from this comment? https://github.com/bytecodealliance/wasmtime/issues/9766

Wasmtime GitHub notifications bot (Dec 10 2024 at 11:45):

MarinPostma updated PR #9762.

Wasmtime GitHub notifications bot (Dec 10 2024 at 12:10):

MarinPostma updated PR #9762.

Wasmtime GitHub notifications bot (Dec 10 2024 at 12:54):

saulecabrera submitted PR review.

Wasmtime GitHub notifications bot (Dec 10 2024 at 13:11):

saulecabrera merged PR #9762.

Last updated: Dec 23 2024 at 12:05 UTC