Wasmtime GitHub notifications bot (Dec 06 2024 at 19:09): Wasmtime GitHub notifications bot (Dec 06 2024 at 19:09):saulecabrera opened PR #9757 from saulecabrera:winch-improve-call-state to bytecodealliance:main:
This commit aims to improve the consistency of call emission in Winch.
Prior to this commit, the calling convention at Winch's assembler layer was hardcoded. Even though the calling convention invariants are correctly handled early on in the code generation process and this has no effect on the generated code, it could lead to subtle bugs if Cranelift's emission infrastructure changes. It could also be confusing when trying to implement call instrutions for other backends.
This change is motivated by some of the questions in https://github.com/bytecodealliance/wasmtime/pull/9751
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 06 2024 at 19:09):saulecabrera requested fitzgen for a review on PR #9757.
Wasmtime GitHub notifications bot (Dec 06 2024 at 19:09):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #9757.
Wasmtime GitHub notifications bot (Dec 06 2024 at 19:21):saulecabrera updated PR #9757.
Wasmtime GitHub notifications bot (Dec 06 2024 at 19:49):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Dec 06 2024 at 20:08):fitzgen merged PR #9757.
Last updated: Dec 23 2024 at 13:07 UTC