Stream: git-wasmtime

Topic: wasmtime / PR #9756 cpp demangling check for demangling e...

Wasmtime GitHub notifications bot (Dec 06 2024 at 18:40):

chobermaier requested alexcrichton for a review on PR #9756.

Wasmtime GitHub notifications bot (Dec 06 2024 at 18:40):

chobermaier opened PR #9756 from chobermaier:main to bytecodealliance:main:

The use of cpp_demangle in crates/environ/src/demangling.rs missed a check if demangling would actually succeed.

This PR's wraps the use of cpp_demangle with an explicitly call of demangle and can therefore check its Result.
The current implicit demangle call did not check this result. In some cases this lead to failed unwrapping in instantiate.rs.

see issue #9753

Wasmtime GitHub notifications bot (Dec 06 2024 at 18:40):

chobermaier requested wasmtime-core-reviewers for a review on PR #9756.

Wasmtime GitHub notifications bot (Dec 06 2024 at 19:30):

alexcrichton submitted PR review:

Thanks for this!

Wasmtime GitHub notifications bot (Dec 06 2024 at 19:30):

alexcrichton edited PR #9756:

The use of cpp_demangle in crates/environ/src/demangling.rs missed a check if demangling would actually succeed.

This PR's wraps the use of cpp_demangle with an explicitly call of demangle and can therefore check its Result.
The current implicit demangle call did not check this result. In some cases this lead to failed unwrapping in instantiate.rs.

Closes #9753

Wasmtime GitHub notifications bot (Dec 06 2024 at 19:46):

alexcrichton merged PR #9756.

Last updated: Dec 23 2024 at 12:05 UTC