Stream: git-wasmtime

Topic: wasmtime / PR #9755 Use `runner.os` in CI configuration more

Wasmtime GitHub notifications bot (Dec 06 2024 at 16:07):

alexcrichton requested fitzgen for a review on PR #9755.

Wasmtime GitHub notifications bot (Dec 06 2024 at 16:07):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9755.

Wasmtime GitHub notifications bot (Dec 06 2024 at 16:07):

alexcrichton opened PR #9755 from alexcrichton:use-runner-os to bytecodealliance:main:

Instead of using matrix.os which can change over time as images change instead use runner.os to both name jobs and have conditions on jobs. This couples it more closely to what's intended, the choice of OS, rather than image version.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 06 2024 at 16:28):

alexcrichton updated PR #9755.

Wasmtime GitHub notifications bot (Dec 06 2024 at 16:29):

alexcrichton commented on PR #9755:

Ok so surprise to me but apparently you can't use runner.os in the name of a job

Wasmtime GitHub notifications bot (Dec 06 2024 at 17:46):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 06 2024 at 18:08):

alexcrichton merged PR #9755.

Last updated: Dec 23 2024 at 12:05 UTC