Stream: git-wasmtime

Topic: wasmtime / PR #9754 Don't cancel workflows on Windows run...


view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2024 at 15:58):

alexcrichton requested cfallin for a review on PR #9754.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2024 at 15:58):

alexcrichton opened PR #9754 from alexcrichton:update-ci-cancel to bytecodealliance:main:

Our CI has configuration such that on failure of any job it cancels the entire workflow run. This means that if a failure is quickly encountered it doesn't wait for the entire workflow to finish just to report the failure, clearing out the queue of failing PRs faster. This doesn't work well on Windows runners though where often the cancellation and marking the job as failed race. The winner of the race is often the cancellation which means that there's no listed failure in 100+ jobs which can be frustrating.

Instead centralize this cancellation logic in one helper and additionally add a condition where it doesn't cancel on Windows platforms. That means that failures on windows won't be fail-fast, but that's sort of the best that we can do for now.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2024 at 15:58):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9754.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2024 at 16:05):

alexcrichton updated PR #9754.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2024 at 17:47):

cfallin submitted PR review:

Thanks for fixing this up!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 06 2024 at 18:04):

cfallin merged PR #9754.


Last updated: Dec 23 2024 at 12:05 UTC