Wasmtime GitHub notifications bot (Dec 06 2024 at 14:15): Wasmtime GitHub notifications bot (Dec 06 2024 at 14:15):saulecabrera opened PR #9750 from saulecabrera:winch-minor-improvements-to-fuel-checks to bytecodealliance:main:
This commits ports the suggestions made in https://github.com/bytecodealliance/wasmtime/pull/9737 to fuel checks.
Namely
- Prefer the usage of
*_regover*_var- Add a couple of disassembly tests
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 06 2024 at 14:15):saulecabrera requested cfallin for a review on PR #9750.
Wasmtime GitHub notifications bot (Dec 06 2024 at 14:15):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #9750.
Wasmtime GitHub notifications bot (Dec 06 2024 at 14:15):saulecabrera requested wasmtime-core-reviewers for a review on PR #9750.
Wasmtime GitHub notifications bot (Dec 06 2024 at 14:15):saulecabrera requested alexcrichton for a review on PR #9750.
Wasmtime GitHub notifications bot (Dec 06 2024 at 14:28):saulecabrera updated PR #9750.
Wasmtime GitHub notifications bot (Dec 06 2024 at 15:45):github-actions[bot] commented on PR #9750:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 06 2024 at 17:41):fitzgen submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Dec 06 2024 at 18:34):saulecabrera updated PR #9750.
Wasmtime GitHub notifications bot (Dec 06 2024 at 18:34):saulecabrera has enabled auto merge for PR #9750.
Wasmtime GitHub notifications bot (Dec 06 2024 at 19:00):saulecabrera merged PR #9750.
Last updated: Dec 23 2024 at 12:05 UTC