Wasmtime GitHub notifications bot (Dec 05 2024 at 23:17): Wasmtime GitHub notifications bot (Dec 05 2024 at 23:17):alexcrichton opened PR #9749 from alexcrichton:pulley-endian-docs to bytecodealliance:main:
Just had some discussion with Nick about this that felt best to immortalize in documentation rather than just having it in our heads.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 05 2024 at 23:17):alexcrichton requested abrown for a review on PR #9749.
Wasmtime GitHub notifications bot (Dec 05 2024 at 23:17):alexcrichton requested wasmtime-default-reviewers for a review on PR #9749.
Wasmtime GitHub notifications bot (Dec 05 2024 at 23:44):abrown submitted PR review.
Wasmtime GitHub notifications bot (Dec 05 2024 at 23:44):abrown created PR review comment:
/// One final note is that this notably contrasts with native CPUs where
Wasmtime GitHub notifications bot (Dec 05 2024 at 23:44):abrown created PR review comment:
/// 3. Always store the values in this union as little-endian. This means that
Wasmtime GitHub notifications bot (Dec 06 2024 at 01:05):github-actions[bot] commented on PR #9749:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "pulley"Thus the following users have been cc'd because of the following labels:
- fitzgen: pulley
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 06 2024 at 15:45):alexcrichton updated PR #9749.
Wasmtime GitHub notifications bot (Dec 06 2024 at 15:45):alexcrichton has enabled auto merge for PR #9749.
Wasmtime GitHub notifications bot (Dec 06 2024 at 16:18):alexcrichton merged PR #9749.
Last updated: Dec 23 2024 at 12:05 UTC