Wasmtime GitHub notifications bot (Dec 05 2024 at 19:56): Wasmtime GitHub notifications bot (Dec 05 2024 at 19:56):alexcrichton opened PR #9745 from alexcrichton:pulley-runtime to bytecodealliance:main:
This PR is based on https://github.com/bytecodealliance/wasmtime/pull/9743 and https://github.com/bytecodealliance/wasmtime/pull/9744 and those should be reviewed first.
Opening this to get a full run of CI to see what happens on these platforms...
Wasmtime GitHub notifications bot (Dec 05 2024 at 21:44):github-actions[bot] commented on PR #9745:
Label Messager: wasmtime:config
It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:
[ ] If you added a new
Configmethod, you wrote extensive documentation for
it.<details>
Our documentation should be of the following form:
```text
Short, simple summary sentence.More details. These details can be multiple paragraphs. There should be
information about not just the method, but its parameters and results as
well.Is this method fallible? If so, when can it return an error?
Can this method panic? If so, when does it panic?
Example
Optional example here.
```</details>
[ ] If you added a new
Configmethod, or modified an existing one, you
ensured that this configuration is exercised by the fuzz targets.<details>
For example, if you expose a new strategy for allocating the next instance
slot inside the pooling allocator, you should ensure that at least one of our
fuzz targets exercises that new strategy.Often, all that is required of you is to ensure that there is a knob for this
configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
of its nestedstructs).Rarely, this may require authoring a new fuzz target to specifically test this
configuration. See [our docs on fuzzing][fuzzing-docs] for more details.</details>
[ ] If you are enabling a configuration option by default, make sure that it
has been fuzzed for at least two weeks before turning it on by default.[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html
<details>
To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.
To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.</details>
Wasmtime GitHub notifications bot (Dec 06 2024 at 15:40):alexcrichton updated PR #9745.
Wasmtime GitHub notifications bot (Dec 06 2024 at 19:46):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Dec 06 2024 at 19:46):fitzgen created PR review comment:
Can we make these precise for 64- and 32-bit archs? Because otherwise we might shrink it, forget to update these tests, and then regress the size again back to its current size.
Wasmtime GitHub notifications bot (Dec 06 2024 at 19:46):fitzgen created PR review comment:
Is this not going to break for the crates which support 32-bit but don't have a
tests/wast.rs? I.e. all of them other thanwasmtime? But even thewasmtimecrate doesn't have that test, onlywasmtime-clidoes... I guess I am pretty confused around the logic here...
Wasmtime GitHub notifications bot (Dec 06 2024 at 19:46):fitzgen created PR review comment:
@Kmeakin, happen to know how we can properly get access to these JIT code registration functions so that profiling and debugging and all that with the system tools is a better experience?
Wasmtime GitHub notifications bot (Dec 06 2024 at 19:59):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Dec 06 2024 at 19:59):alexcrichton created PR review comment:
This is abusing the fact that
cargo test --workspace --test wastonly actually executes tests namedwastand everything else is ignored. So this effectively runscargo test --test wastand nothing else is namedwast.In the long-run I want to get more 32-bit tests running, just needs more support in Pulley for that.
Wasmtime GitHub notifications bot (Dec 06 2024 at 20:01):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Dec 06 2024 at 20:01):alexcrichton created PR review comment:
Good point yeah, I'll try. It's not quite as easy as 32-or-64 since the size differs between x86 and arm due to the alignment of u64 being different, but I'll probably just make these tests 64-bit only.
Wasmtime GitHub notifications bot (Dec 06 2024 at 20:41):alexcrichton updated PR #9745.
Wasmtime GitHub notifications bot (Dec 06 2024 at 20:41):alexcrichton has marked PR #9745 as ready for review.
Wasmtime GitHub notifications bot (Dec 06 2024 at 20:41):alexcrichton requested cfallin for a review on PR #9745.
Wasmtime GitHub notifications bot (Dec 06 2024 at 20:41):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9745.
Wasmtime GitHub notifications bot (Dec 06 2024 at 20:41):alexcrichton requested wasmtime-core-reviewers for a review on PR #9745.
Wasmtime GitHub notifications bot (Dec 06 2024 at 20:41):alexcrichton requested wasmtime-default-reviewers for a review on PR #9745.
Wasmtime GitHub notifications bot (Dec 06 2024 at 20:41):alexcrichton has enabled auto merge for PR #9745.
Wasmtime GitHub notifications bot (Dec 06 2024 at 21:13):alexcrichton merged PR #9745.
Last updated: Dec 23 2024 at 12:05 UTC