Stream: git-wasmtime

Topic: wasmtime / PR #9741 Default to Pulley on cranelift/winch-...


view this post on Zulip Wasmtime GitHub notifications bot (Dec 05 2024 at 01:49):

alexcrichton requested fitzgen for a review on PR #9741.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 05 2024 at 01:49):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9741.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 05 2024 at 01:49):

alexcrichton opened PR #9741 from alexcrichton:pulley-default-target to bytecodealliance:main:

This commit updates the selection of the default target used by a Config to take into account the host architecture and possibly use Pulley instead of the host target itself. The goal here is that when a target isn't explicitly configured then Wasmtime is tasked with picking a reasonable default to execute code with. If neither Winch nor Cranelift has any support then the only way to possibly execute code would be with Pulley, so in these situations pulley becomes the default target.

The goal of this change is to make testing easier on 32-bit platforms where there is no compiler support. This means we won't have to update all tests to explicitly configure pulley on unsupported platforms. Additionally this means that an eventual wasmtime executable for 32-bit platforms will use Pulley by default and won't need any extra configuration.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Dec 05 2024 at 03:50):

github-actions[bot] commented on PR #9741:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html


<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

view this post on Zulip Wasmtime GitHub notifications bot (Dec 05 2024 at 18:58):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 05 2024 at 19:24):

alexcrichton updated PR #9741.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 05 2024 at 19:24):

alexcrichton has enabled auto merge for PR #9741.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 05 2024 at 19:50):

alexcrichton merged PR #9741.


Last updated: Dec 23 2024 at 12:05 UTC