Stream: git-wasmtime

Topic: wasmtime / PR #9740 Tweak rules for traps in CLIF transl...

Wasmtime GitHub notifications bot (Dec 05 2024 at 01:25):

alexcrichton requested fitzgen for a review on PR #9740.

Wasmtime GitHub notifications bot (Dec 05 2024 at 01:25):

alexcrichton opened PR #9740 from alexcrichton:pulley-traps-and-clif to bytecodealliance:main:

This commit updates how the signals_based_traps setting is read for
various instruction generation during the wasm-to-CLIF translation
phase. Specifically this splits the signals_based_traps configuration
into one for "general CLIF instructions can trap" and another for
"memory traps are allowed". These settings are based on
signals_based_traps but then differ for Pulley. For example Pulley
allows general instructions to trap since that just halts the
interpreter, but memory-related instructions can't trap since segfaults
aren't caught during the execution of Pulley. These settings then take
Pulley into account to assist in translating Pulley compatibly by
default.

Wasmtime GitHub notifications bot (Dec 05 2024 at 01:25):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9740.

Wasmtime GitHub notifications bot (Dec 05 2024 at 01:26):

alexcrichton commented on PR #9740:

I'll note that this is temporarily based on https://github.com/bytecodealliance/wasmtime/pull/9736, so only the second commit is part of this PR

Wasmtime GitHub notifications bot (Dec 05 2024 at 03:03):

github-actions[bot] commented on PR #9740:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

• fitzgen: wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Dec 05 2024 at 17:54):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 05 2024 at 17:54):

fitzgen created PR review comment:

Was this test file intentionally deleted?

Wasmtime GitHub notifications bot (Dec 05 2024 at 18:10):

alexcrichton updated PR #9740.

Wasmtime GitHub notifications bot (Dec 05 2024 at 18:11):

alexcrichton created PR review comment:

Ah yes sorry forgot to call this out, the changes in this PR change codegen for pulley where it uses uadd_overflow_trap now instead of add/compare which isn't supported on Pulley yet, so this test no longer passes.

Wasmtime GitHub notifications bot (Dec 05 2024 at 18:11):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 05 2024 at 18:11):

alexcrichton has enabled auto merge for PR #9740.

Wasmtime GitHub notifications bot (Dec 05 2024 at 18:45):

alexcrichton merged PR #9740.

Last updated: Dec 23 2024 at 12:05 UTC