Wasmtime GitHub notifications bot (Dec 04 2024 at 20:54): Wasmtime GitHub notifications bot (Dec 04 2024 at 20:54):alexcrichton requested fitzgen for a review on PR #9736.
Wasmtime GitHub notifications bot (Dec 04 2024 at 20:54):alexcrichton requested wasmtime-core-reviewers for a review on PR #9736.
Wasmtime GitHub notifications bot (Dec 04 2024 at 20:54):alexcrichton opened PR #9736 from alexcrichton:remove-func-environment to bytecodealliance:main:
This is a leftover from the
cranelift-wasmdays and it's not necessary any more. Remove it and have an inherent impl for the trait methods instead.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 04 2024 at 22:46):github-actions[bot] commented on PR #9736:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "wasmtime:ref-types"Thus the following users have been cc'd because of the following labels:
- fitzgen: wasmtime:ref-types
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 05 2024 at 17:38):fitzgen submitted PR review:
Very nice! I wanted to get to this eventually, happy to have been beaten in the race
Wasmtime GitHub notifications bot (Dec 05 2024 at 17:58):alexcrichton merged PR #9736.
Last updated: Dec 23 2024 at 12:05 UTC