Stream: git-wasmtime

Topic: wasmtime / PR #9735 pulley: Track faulting opcode in stac...

Wasmtime GitHub notifications bot (Dec 04 2024 at 19:06):

alexcrichton opened PR #9735 from alexcrichton:pulley-track-trapping-opcode to bytecodealliance:main:

This commit updates the pulley Encode trait to have a WIDTH associated with it to be able to calculate the size of an instruction by name rather than hard-coding instruction details in multiple locations. This constant is procedurally generated per-instruction given the definition of the instruction. This for now assumes there are no variable-width instructions.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 04 2024 at 19:07):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9735.

Wasmtime GitHub notifications bot (Dec 04 2024 at 19:10):

alexcrichton requested fitzgen for a review on PR #9735.

Wasmtime GitHub notifications bot (Dec 04 2024 at 19:17):

alexcrichton updated PR #9735.

Wasmtime GitHub notifications bot (Dec 04 2024 at 19:44):

github-actions[bot] commented on PR #9735:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "pulley"

Thus the following users have been cc'd because of the following labels:

• fitzgen: pulley

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Dec 04 2024 at 20:18):

alexcrichton updated PR #9735.

Wasmtime GitHub notifications bot (Dec 05 2024 at 17:35):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 05 2024 at 17:35):

fitzgen created PR review comment:

Does this need to add one for the extended op prefix byte?

Wasmtime GitHub notifications bot (Dec 05 2024 at 18:12):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 05 2024 at 18:12):

alexcrichton created PR review comment:

Ah that's covered in the width() return value internall itself as the WIDTH associated constant accounts for the extended-op prefix.

Wasmtime GitHub notifications bot (Dec 05 2024 at 18:29):

alexcrichton merged PR #9735.

Last updated: Dec 23 2024 at 12:05 UTC