Wasmtime GitHub notifications bot (Dec 04 2024 at 18:12): Wasmtime GitHub notifications bot (Dec 04 2024 at 18:12):alexcrichton opened PR #9733 from alexcrichton:pulley-sign-extend to bytecodealliance:main:
The
uextendandsextendlowerings aren't done yet but this should help fill out ABI bits instead of panicking. Example tests are added showing what support is added here.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 04 2024 at 18:12):alexcrichton has marked PR #9733 as ready for review.
Wasmtime GitHub notifications bot (Dec 04 2024 at 18:12):alexcrichton requested fitzgen for a review on PR #9733.
Wasmtime GitHub notifications bot (Dec 04 2024 at 18:12):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9733.
Wasmtime GitHub notifications bot (Dec 04 2024 at 18:12):alexcrichton requested wasmtime-default-reviewers for a review on PR #9733.
Wasmtime GitHub notifications bot (Dec 04 2024 at 19:44):github-actions[bot] commented on PR #9733:
Subscribe to Label Action
cc @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "pulley"Thus the following users have been cc'd because of the following labels:
- fitzgen: pulley
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 05 2024 at 17:29):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Dec 05 2024 at 17:29):fitzgen created PR review comment:
Maybe leave this assertion? Perhaps as debug?
Wasmtime GitHub notifications bot (Dec 05 2024 at 18:10):alexcrichton updated PR #9733.
Wasmtime GitHub notifications bot (Dec 05 2024 at 18:10):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Dec 05 2024 at 18:10):alexcrichton created PR review comment:
Oops nah yeah this was just accidentally deleted
Wasmtime GitHub notifications bot (Dec 05 2024 at 18:10):alexcrichton has enabled auto merge for PR #9733.
Wasmtime GitHub notifications bot (Dec 05 2024 at 18:41):alexcrichton merged PR #9733.
Last updated: Dec 23 2024 at 13:07 UTC