Stream: git-wasmtime

Topic: wasmtime / PR #9724 Fix `wasmtime::FieldType::matches` fo...

Wasmtime GitHub notifications bot (Dec 03 2024 at 23:07):

fitzgen opened PR #9724 from fitzgen:field-type-subtyping-and-mutability to bytecodealliance:main:

Similar to https://github.com/bytecodealliance/wasm-tools/pull/1934 but for wasmtime::FieldType.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 03 2024 at 23:07):

fitzgen requested wasmtime-core-reviewers for a review on PR #9724.

Wasmtime GitHub notifications bot (Dec 03 2024 at 23:07):

fitzgen requested alexcrichton for a review on PR #9724.

Wasmtime GitHub notifications bot (Dec 03 2024 at 23:10):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 03 2024 at 23:10):

alexcrichton created PR review comment:

This is still a valid optimization to do though, right? IIRC signatures() below grabs a lock so ideally we'd keep this.

Wasmtime GitHub notifications bot (Dec 03 2024 at 23:12):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Dec 03 2024 at 23:12):

fitzgen created PR review comment:

signatures() doesn't grab a lock, the methods on it do, and the is_subtype method already has this optimization as a fast path, so no need to duplicate it all over the place.

Wasmtime GitHub notifications bot (Dec 03 2024 at 23:35):

fitzgen merged PR #9724.

Last updated: Dec 23 2024 at 12:05 UTC