Wasmtime GitHub notifications bot (Dec 03 2024 at 21:23): Wasmtime GitHub notifications bot (Dec 03 2024 at 21:23):alexcrichton requested cfallin for a review on PR #9722.
Wasmtime GitHub notifications bot (Dec 03 2024 at 21:23):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9722.
Wasmtime GitHub notifications bot (Dec 03 2024 at 21:23):alexcrichton opened PR #9722 from alexcrichton:fix-pulley-virtual-adjust to bytecodealliance:main:
This fixes the output of the pulley cranelift backend with respect to virtual stack offsets and adjustments for calls with stack parameters and results. Previously the virtual stack pointer was updated but the rest of the backend assumed the real stack pointer was updated. This updates the pulley backend to match the other backends in this respects and fixes a test on my "more complete pulley integration" branch.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 03 2024 at 21:24):alexcrichton commented on PR #9722:
I'll fully admit I don't know what a virtual sp offset is so I could be completely off-base here. The main data I'm going on is "fixes a bug in another branch".
Wasmtime GitHub notifications bot (Dec 03 2024 at 21:24):alexcrichton edited a comment on PR #9722:
I'll fully admit I don't know what a virtual sp offset is so I could be completely off-base here. The main data I'm going on is "fixes a bug in another branch". (happy to provide more info such as the branch and/or migrate more tests here if that's desired)
Wasmtime GitHub notifications bot (Dec 03 2024 at 23:34):cfallin submitted PR review:
LGTM! Virtual-SP was a mechanism we used to handle frame layout relative to sp while sp moved during a callsite sequence; it went away in #8631, so probably it's a vestigial artifact here from Pulley's early development history (?). In any case, LGTM.
Wasmtime GitHub notifications bot (Dec 04 2024 at 00:21):alexcrichton updated PR #9722.
Wasmtime GitHub notifications bot (Dec 04 2024 at 00:21):alexcrichton has enabled auto merge for PR #9722.
Wasmtime GitHub notifications bot (Dec 04 2024 at 00:54):alexcrichton merged PR #9722.
Last updated: Dec 23 2024 at 12:05 UTC