Stream: git-wasmtime

Topic: wasmtime / PR #9718 pulley: Fill out more bits and pieces...

Wasmtime GitHub notifications bot (Dec 03 2024 at 19:03):

alexcrichton opened PR #9718 from alexcrichton:pulley-stack-alloc to bytecodealliance:main:

• Use push_frame and pop_frame in the Cranelift backend.
• Use dedicated instructions for modifying the stack pointer
  • decrementing the stack pointer is always checked
  • incrementing the stack pointer is checked in debug mode
• Disregard stack probes and stack_limit checks as they're both unnecessary for Pulley (all stack allocations are checked).

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 03 2024 at 19:03):

alexcrichton requested abrown for a review on PR #9718.

Wasmtime GitHub notifications bot (Dec 03 2024 at 19:03):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #9718.

Wasmtime GitHub notifications bot (Dec 03 2024 at 19:03):

alexcrichton requested pchickey for a review on PR #9718.

Wasmtime GitHub notifications bot (Dec 03 2024 at 19:03):

alexcrichton requested wasmtime-core-reviewers for a review on PR #9718.

Wasmtime GitHub notifications bot (Dec 03 2024 at 19:03):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9718.

Wasmtime GitHub notifications bot (Dec 03 2024 at 19:08):

alexcrichton updated PR #9718.

Wasmtime GitHub notifications bot (Dec 03 2024 at 20:38):

alexcrichton updated PR #9718.

Wasmtime GitHub notifications bot (Dec 03 2024 at 20:38):

alexcrichton updated PR #9718.

Wasmtime GitHub notifications bot (Dec 03 2024 at 21:45):

github-actions[bot] commented on PR #9718:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "cranelift", "pulley"

Thus the following users have been cc'd because of the following labels:

• fitzgen: pulley

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Dec 04 2024 at 01:16):

alexcrichton updated PR #9718.

Wasmtime GitHub notifications bot (Dec 04 2024 at 01:22):

alexcrichton updated PR #9718.

Wasmtime GitHub notifications bot (Dec 04 2024 at 17:18):

abrown submitted PR review:

LGTM!

Wasmtime GitHub notifications bot (Dec 04 2024 at 17:34):

abrown merged PR #9718.

Last updated: Dec 23 2024 at 13:07 UTC