Stream: git-wasmtime

Topic: wasmtime / PR #9717 Pin some runner images

Wasmtime GitHub notifications bot (Dec 03 2024 at 16:41):

alexcrichton requested pchickey for a review on PR #9717.

Wasmtime GitHub notifications bot (Dec 03 2024 at 16:41):

alexcrichton requested wasmtime-default-reviewers for a review on PR #9717.

Wasmtime GitHub notifications bot (Dec 03 2024 at 16:41):

alexcrichton opened PR #9717 from alexcrichton:pin-ci-images to bytecodealliance:main:

For the larger test/build jobs use some variables in the *.js files calculating the matrix to pin the images to fixed versions of GitHub actions images. For the main.yml file instead of changing everything over to a pin only do the ones that are currently failing on the ubuntu-24.04 update. The hope is that there's only a few locations to update pinned versions in the future, and we'll need to keep an eye on CI warnings and such to know when to update these pins in the future.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Dec 03 2024 at 16:41):

alexcrichton commented on PR #9717:

(result of learnings from https://github.com/bytecodealliance/wasmtime/pull/9715)

Wasmtime GitHub notifications bot (Dec 03 2024 at 16:46):

alexcrichton commented on PR #9717:

For some longer-form rationale, my thinking here is it's not an unreasonable default to stick to *-latest by default, but for the "big" jobs it's probably more reasonable to use versioned images by default and explicitly update them to catch issues. That's where the *.js files all use versioned images and unfortunately we need two versioned images in main.yml, but I'm thinking we shouldn't go "version all the things" in the main.yml file just yet.

Wasmtime GitHub notifications bot (Dec 04 2024 at 01:25):

alexcrichton requested cfallin for a review on PR #9717.

Wasmtime GitHub notifications bot (Dec 04 2024 at 05:03):

cfallin submitted PR review.

Wasmtime GitHub notifications bot (Dec 04 2024 at 05:20):

cfallin merged PR #9717.

Last updated: Dec 23 2024 at 13:07 UTC